Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Sep 2, 2025

Closes #331 (review)

Description

This PR removes backstack on success navigation. Also fix QuickPay success screen

Preview

onchain-and-ln.mp4
quick-pay.mp4
pin.mp4

QA Notes

Tested:
Try to swipe back in:

  • On-chain
  • Lightning
  • Quickpay
  • Set PIN

@jvsena42 jvsena42 self-assigned this Sep 2, 2025
@jvsena42 jvsena42 marked this pull request as draft September 2, 2025 12:56
@jvsena42 jvsena42 marked this pull request as ready for review September 2, 2025 13:49
@jvsena42 jvsena42 requested a review from ovitrif September 3, 2025 09:37
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Tested:

  • send onchain 🟢 - sheet dismissed on swipe to nav back
  • send lightning 🟢 - same
  • quickpay 🟢 - same

EDIT: send onchain fix confirmed too.

@ovitrif ovitrif merged commit 4ba7a25 into master Sep 3, 2025
5 checks passed
@ovitrif ovitrif deleted the fix/remove-backstack-success-sheet branch September 3, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants